Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[occm] LoadBalancer ProxyProtocol v2 feature #2585

Open
nicolaslacroux opened this issue Apr 26, 2024 · 2 comments
Open

[occm] LoadBalancer ProxyProtocol v2 feature #2585

nicolaslacroux opened this issue Apr 26, 2024 · 2 comments

Comments

@nicolaslacroux
Copy link

/kind feature

As a Kubernetes + occm user I would like to enabling the ProxyProtocol v2 as valid protocol with Octavia Load balancer.

What happened:
Currently, it is not possible to create an Octavoia load balancer from the OCCM using the "ProxyProtocolv2" protocol.

loadbalancer.openstack.org/proxy-protocol: "true" # Enable ProxyProtocolv1
loadbalancer.openstack.org/proxy-protocol: "false" # Default value, no proxy protocol enable

What you expected to happen:
Add proxy-protocol v2 annotations at Loadbalancer creation (Kubernetes service type LoadBalancer):

loadbalancer.openstack.org/proxy-protocol: "true" # Enable ProxyProtocolv1
loadbalancer.openstack.org/proxy-protocol: "v1" # Enable ProxyProtocolv1
loadbalancer.openstack.org/proxy-protocol: "v2" # Enable ProxyProtocolv2
loadbalancer.openstack.org/proxy-protocol: "false" # Default value, no proxy protocol enable 

Anything else we need to know?:
Related Octavia documentation:
https://docs.openstack.org/api-ref/load-balancer/v2/#protocol-combinations-listener-pool

As an Openstack Public Cloud Provider we are currently working on a custom CCM implementation, for this reason we can potentially do the PR associated with this request, but we'd like to at least validate the implementation before starting developments.

@zetaab
Copy link
Member

zetaab commented Apr 26, 2024

@nicolaslacroux for me the spec seems valid. Another option could be add loadbalancer.openstack.org/proxy-protocol-version annotation to specify the version. However, as I see it we could do it in one annotation that can accept values that you mentioned.

cc @dulek do you have opinion?

@dulek
Copy link
Contributor

dulek commented May 23, 2024

I like the design proposed and I see value in not introducing new annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants