Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manila-csi-plugin]: use new access rules GET method when possible #2277

Open
kayrus opened this issue Jun 20, 2023 · 6 comments
Open

[manila-csi-plugin]: use new access rules GET method when possible #2277

kayrus opened this issue Jun 20, 2023 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kayrus
Copy link
Contributor

kayrus commented Jun 20, 2023

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:

Some OpenStack deployments can have middlewares that limit an amount of POST/PUT requests, which are categorized as write requests. One of the wrongly categorized request is a deprecated list access rules action.

What you expected to happen:

In order to prevent excessive requests rate limiting, CSI Manila plugin should support a newer Manila API call.

How to reproduce it:

n/a

Anything else we need to know?:

See also terraform-provider-openstack/terraform-provider-openstack#1582

Environment:

  • openstack-cloud-controller-manager(or other related binary) version: n/a
  • OpenStack version: n/a
  • Others: n/a

cc @Carthaca

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 20, 2023
@mdbooth
Copy link
Contributor

mdbooth commented Jun 20, 2023

According to https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html#id40 it looks like this microversion has been available since Rocky which, according to https://releases.openstack.org/ is the oldest release which isn't EOL.

That said, if we bumped the minimum microversion to Rocky it still might make folks like @lentzi90 unhappy. We should discuss which versions of OpenStack we want to support.

@kayrus
Copy link
Contributor Author

kayrus commented Jun 20, 2023

@mdbooth see a PR that corresponds to terraform-provider-openstack/terraform-provider-openstack#1582. Before calling the share access list, we check API microversions.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2024
@gouthampacha
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2024
@gouthampacha
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants