You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What would you like to be added:
Depart away from Helm 3 way to install CRDs and use a subchart for it.
Why is this needed:
Moving CRDs to a chart solves several issues: clean uninstall, possibility for upgrades, templating.
Motivation and Context
My main motivation is to have a better experience when managing this operator with Argo CD. That said, moving away from Helm 3 approach to install CRDs might be helpful in other scenarios too. I'm posting the full rationale below.
CRDs installed from crds folder are not included into the helm release.
Additionally, it is not possible to template CRDs in Helm 3 in the crds folder.
The following comes from helm best practices around CRDs:
There is no support at this time for upgrading or deleting CRDs using Helm. This was an explicit decision after much community discussion due to the danger for unintentional data loss.
Another alternatively, which is what I propose and comes from Helm page:
Another way to do this is to put the CRD definition in one chart, and then put any resources that use that CRD in another chart.
In this method, each chart must be installed separately. However, this workflow may be more useful for cluster operators who have admin access to a cluster
cmontemuino
changed the title
Installa CRDs from a subchart instead of using Helm 3 crds directory
Install CRDs from a subchart instead of using Helm 3 crds directory
Mar 22, 2024
What would you like to be added:
Depart away from Helm 3 way to install CRDs and use a subchart for it.
Why is this needed:
Moving CRDs to a chart solves several issues: clean uninstall, possibility for upgrades, templating.
Motivation and Context
My main motivation is to have a better experience when managing this operator with Argo CD. That said, moving away from Helm 3 approach to install CRDs might be helpful in other scenarios too. I'm posting the full rationale below.
Helm 3 does not manage CRDs (see https://helm.sh/docs/chart_best_practices/custom_resource_definitions/).
helm uninstall
won't remove CRDs, andhelm updgrade
won't upgrade them. Manual intervention is required with the current setup.crds
folder are not included into the helm release.crds
folder.The following comes from helm best practices around CRDs:
ref: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you
Another alternatively, which is what I propose and comes from Helm page:
ref: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-2-separate-charts
I'm completely fine to open a PR with the required refactoring, without impacting current installations.
The text was updated successfully, but these errors were encountered: