Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spiffe support #1186

Open
marquiz opened this issue Apr 25, 2023 · 6 comments · May be fixed by #1663
Open

Spiffe support #1186

marquiz opened this issue Apr 25, 2023 · 6 comments · May be fixed by #1663
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@marquiz
Copy link
Contributor

marquiz commented Apr 25, 2023

What would you like to be added:

Support SPIFFE for verifying nfd-worker/labeler IDs. For example, utilize spiffe IDs for verifying the identity of creator of NodeFeature objects, so that an actor from node A will not be able to modify properties of node B. This would also add one extra layer of protection (in addition to RBAC) on who is authorized to modify nodes with NodeFeature objects.

To simplify, gRPC could be possibly left out-of-scope, if needed, as it's being phased out.

Inspired by comment from @AhmedGrati on the node-feature-discovery slack channel.

Why is this needed:

Improved security

@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 25, 2023
@AhmedGrati
Copy link

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2024
@AhmedGrati
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@ArangoGutierrez
Copy link
Contributor

Only comment, is make sure is optional and easy to enable/disable from HELM

@AhmedGrati
Copy link

@ArangoGutierrez yes that's for sure!

@TessaIO TessaIO linked a pull request Apr 14, 2024 that will close this issue
2 tasks
@TessaIO
Copy link
Contributor

TessaIO commented Apr 22, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants