Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change a task name in preinstall/0080-system-configurations.yml #11171

Merged
merged 1 commit into from May 14, 2024
Merged

Change a task name in preinstall/0080-system-configurations.yml #11171

merged 1 commit into from May 14, 2024

Conversation

kimsehwan96
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:

These kernel parameters are the expected values for kubelet to operate(not the kube-bench), so it would be good to change the task name for a clearer understanding of its operation.

Which issue(s) this PR fixes:

Fixes: #11170

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Change a task name `Ensure kube-bench parameters are set` into `Ensure kubelet expected parameters are set`  in `roles/kubernetes/preinstall/tasks/0080-system-configurations.yml` for a clearer understanding of its operation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label May 7, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @kimsehwan96. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2024
@mzaian
Copy link
Contributor

mzaian commented May 13, 2024

Thanks @kimsehwan96

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2024
@yankay
Copy link
Member

yankay commented May 14, 2024

Thanks @kimsehwan96
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimsehwan96, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@VannTen
Copy link
Contributor

VannTen commented May 14, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit e410e30 into kubernetes-sigs:master May 14, 2024
60 checks passed
@mzaian mzaian mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

@VannTen VannTen Awaiting requested review from VannTen

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change a task name in preinstall tasks (in 0080-system-configurations.yml )
5 participants
@kimsehwan96 @k8s-ci-robot @mzaian @yankay @VannTen