Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gwctl] (bug too) kubectl-compliant get subcommand with per-resource access #3041

Open
yashvardhan-kukreja opened this issue May 1, 2024 · 1 comment · May be fixed by #3042
Open

[gwctl] (bug too) kubectl-compliant get subcommand with per-resource access #3041

yashvardhan-kukreja opened this issue May 1, 2024 · 1 comment · May be fixed by #3042
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@yashvardhan-kukreja
Copy link
Contributor

yashvardhan-kukreja commented May 1, 2024

What would you like to be added:

The ability to get a specific resource with gwctl like

gwctl get <RESOURCE_TYPE> <NAME>

or

gwctl get <RESOURCE_TYPE>/<NAME>

Why this is needed:

Currently, it's not possible to get a specific resource via gwctl get RESOURCE_TYPE RESOURCE_NAME because of a max limit of 1 arg set up with cobra under get.go

Due to this, the resourcediscovery.Filter's Name attribute becomes unreachable by the user despite it being used under various cases under switch kind

Moreover, the parsing of kind isn't completely compliant with kubectl convention of kubectl get RESOURCE_TYPE/RESOURCE_NAME

Where kubectl parses the kind as RESOURCE_TYPE and name as RESOURCE_NAME, gwctl blindly parses the kind as RESOURCE_TYPE/RESOURCE_NAME and name as ""

@yashvardhan-kukreja yashvardhan-kukreja added the kind/feature Categorizes issue or PR as related to a new feature. label May 1, 2024
@yashvardhan-kukreja
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant