Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to include the certificate/s in the CapturedResponse of the conformance test #3020

Open
pramodrj07 opened this issue Apr 24, 2024 · 4 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pramodrj07
Copy link

pramodrj07 commented Apr 24, 2024

Request to include the certificate/s in the CapturedResponse of the conformance test:

To verify the certificate served by the listener/service:

During our testing we found that roundtripper.CapturedResponse does not have a certificates field similar to http.Response(https://github.com/golang/go/blob/master/src/crypto/tls/common.go#L265). It would come in handy for testing as we currently have a wrapper for the same.

or If there is any other way in which this is already done, It would be great to know about it

@pramodrj07 pramodrj07 added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 24, 2024
@youngnick
Copy link
Contributor

/assign @snehachhabria

@k8s-ci-robot
Copy link
Contributor

@youngnick: GitHub didn't allow me to assign the following users: snehachhabria.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @snehachhabria

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@snehachhabria
Copy link
Contributor

/assign @snehachhabria

@snehachhabria
Copy link
Contributor

Per the discussion on this issue on the meeting, currently there are no tests in the conformance that are asserting on this, however exposing this will allow the extension of tests to make these assertions as well in the future.

If an unexpected cert is provided there will be a TLS connection error and there is no need to validate the cert in this scenario but for success scenarios additional validation will help assert the cert details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants