Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance - HTTPBackendRef Filter HTTPRouteFilterRequestRedirect #2936

Open
dprotaso opened this issue Apr 3, 2024 · 5 comments
Open

conformance - HTTPBackendRef Filter HTTPRouteFilterRequestRedirect #2936

dprotaso opened this issue Apr 3, 2024 · 5 comments
Assignees
@sharmaansh21
Labels
area/conformance good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@dprotaso
Copy link
Contributor

dprotaso commented Apr 3, 2024 •
edited

What would you like to be added:
Currently there isn't a conformance tests for the HTTPRouteFilterRequestRedirect on the HTTPBackendRef

Why this is needed:
The feature is Extended but there is no way for implementations to specify that they support this feature. Secondly, a conformance test will verify that the implementation is correctly implemented.

/good-first-issue
/help

A good reference on how to write the test please see the following PRs
https://github.com/kubernetes-sigs/gateway-api/pulls?q=is%3Apr+author%3Adprotaso+HTTPBackendRef+
@k8s-ci-robot
Copy link
Contributor

@dprotaso:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

What would you like to be added:
Currently there isn't a conformance tests for the HTTPRouteFilterRequestRedirect on the HTTPBackendRef

Why this is needed:
The feature is Extended but there is no way for implementations to specify that they support this feature. Secondly, a conformance test will verify that the implementation is correctly implemented.

/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 3, 2024
@sharmaansh21
Copy link

@dprotaso Can I also pick this up?

@dprotaso
Copy link
Contributor Author

dprotaso commented Apr 3, 2024

sure
/assign @sharmaansh21

@MovieMaker93
Copy link

@dprotaso Can I also pick this up?

Are you still working on it?

@MovieMaker93
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharmaansh21 sharmaansh21

Labels
area/conformance good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dprotaso @sharmaansh21 @k8s-ci-robot @MovieMaker93