Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image pull progress #1401

Open
ghorbani-ali opened this issue Apr 17, 2024 · 3 comments
Open

Image pull progress #1401

ghorbani-ali opened this issue Apr 17, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@ghorbani-ali
Copy link

What would you like to be added:

Show the total size and progress of the total downloaded size when pulling the image

Why is this needed:

When we pull the images, nothing is displayed about the image size, how many layers are there, or how much is downloaded. This can be most user-friendly.
However, from my study of the contribution documents, I found that to start working on such a change, I need to get approval from your team first.

May I work on this? Any insight?

@ghorbani-ali ghorbani-ali added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 17, 2024
@SergeyKanzhelev
Copy link
Member

What CRI APIs do you want to use for this? From k8s SIG Node we had a few attempts to add new APIs to increase transparency in download progress, but as far as I remember we didn't get far on this.

For the size - you likely will also need a new API call. Or you know a way?

I commented without looking at API, it was long time I checked them.

@saschagrunert
Copy link
Member

This is related to kubernetes/enhancements#3542

@ghorbani-ali
Copy link
Author

ghorbani-ali commented Apr 18, 2024

@SergeyKanzhelev Thanks for your reply.
First, I was wondering if this matter is acceptable to you. After your response, I also briefly reviewed the API project. I found functions there related to image size and returning information. I divided the work into two main parts:

  • Retrieving and displaying the total image size.
  • Size in the process of downloading.

For the first part, as I mentioned, there are already functions in place, but I need to examine them more closely. For the second part, I currently have no ideas and need more time to investigate. Are you in agreement with the overall plan? I would appreciate it if you could share your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

3 participants