Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off deprecated AppArmorProfile CRI API #1378

Closed
roman-kiselenko opened this issue Mar 18, 2024 · 2 comments · Fixed by #1400
Closed

Migrate off deprecated AppArmorProfile CRI API #1378

roman-kiselenko opened this issue Mar 18, 2024 · 2 comments · Fixed by #1400
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@roman-kiselenko
Copy link
Contributor

roman-kiselenko commented Mar 18, 2024

What would you like to be added:

The CRI API LinuxContainerSecurityContext field apparmor_profile has been deprecated in favor of the newer structured apparmor field:

https://github.com/kubernetes/kubernetes/blob/364ef335dbd49bfa3d66dbc606c642481d283851/staging/src/k8s.io/cri-api/pkg/apis/runtime/v1/api.proto#L926-L934

Why is this needed:

The following test might be improved in order to cover new field as well.

if apparmor.IsEnabled() {
BeforeEach(func() {
rc = f.CRIClient.CRIRuntimeClient
ic = f.CRIClient.CRIImageClient
Expect(loadTestProfiles()).NotTo(HaveOccurred())
})

@roman-kiselenko roman-kiselenko added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 18, 2024
@roman-kiselenko
Copy link
Contributor Author

/c @saschagrunert

@roman-kiselenko
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
1 participant