New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation of pod-config and container-config schema #1309
Comments
@ptwales thank you for reaching out! The schemas are mappings to the CRI api fields: https://github.com/kubernetes/cri-api/blob/master/pkg/apis/runtime/v1/api.proto Maybe we can enhance the docs to mention and link them. Do you want to collaborate on this change? |
@saschagrunert those API protocols drill down into the same structs I linked to above. Linking to those would be a least effort solution. Although keeping the version linked in sync with the docs would be an issue. I also don't know how much those types are expected to fluctuate or if they are completely finalized. I humbly think any further documentation should be written by someone who understands the project and isn't just learning it now. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What would you like to be added:
Complete documentation of the schemas for the
pod-config.[yaml|json]
andcontainer-config.[json|yaml]
used by thecrictl run
andcrictl runp
commands. Or links to external documentation if these schemas are defined externally.Why is this needed:
Currently only minimal examples are present in the documentation. Basic fields such as mounts, environment variables, etc. are not mentioned.
I suspect this is entirely defined externally by CRI but I can't find any documentation at all on it's website nor on k8s. Does the documentation for any of these files exist outside of go code?
I've chased down this reference to these:
I don't even know if this is correct though.
The text was updated successfully, but these errors were encountered: