Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: add helm envFrom value parameter #2729

Closed
cesarmira opened this issue Jul 22, 2022 · 8 comments · Fixed by #3683
Closed

Helm: add helm envFrom value parameter #2729

cesarmira opened this issue Jul 22, 2022 · 8 comments · Fixed by #3683
Assignees
@omerap12
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@cesarmira
Copy link

Is your feature request related to a problem?
We define our clusters name as a value in a Kubernetes secret. Then, we set the arg - --cluster-name=$(CLUSTER_NAME) (or clusterName: $(CLUSTER_NAME) in the chart. At the moment, as we can't set the envFrom from the chart, we need to template the chart and apply the resources via flux.

Describe the solution you'd like
Update chart to include the value envFrom.

Describe alternatives you've considered
This is the only was to read secrets as env var.
@kishorj
Copy link
Collaborator

kishorj commented Aug 11, 2022

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 11, 2022
@kishorj kishorj added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 11, 2022
@asim-reza
Copy link

/assign

@asim-reza
Copy link

/unassign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
@harshbhandarivs
Copy link

/assign

@harshbhandarivs
Copy link

/unassign

@omerap12
Copy link
Contributor

omerap12 commented May 5, 2024 •
edited

Hey, if this still necessary I can take it. @cesarmira @kishorj

@omerap12
Copy link
Contributor

omerap12 commented May 7, 2024

/assign

@omerap12 omerap12 mentioned this issue May 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omerap12 omerap12

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added helm envFrom value parameter for cluster-name omerap12/aws-load-balancer-controller
7 participants
@cesarmira @kishorj @k8s-ci-robot @asim-reza @k8s-triage-robot @omerap12 @harshbhandarivs