Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Ingress/Service object annotations to support recently added HTTP client keepalive duration #3670

Closed
kswift opened this issue Apr 29, 2024 · 9 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@kswift
Copy link

kswift commented Apr 29, 2024

Is your feature request related to a problem?
Elastic Load Balancing team recently released HTTP client keepalive duration which can be configured for ALBs -> https://aws.amazon.com/about-aws/whats-new/2024/03/application-load-balancer-http-keepalive-duration/

This keepalive value specifies the maximum amount of time that ALB will maintain an HTTP connection with a client before closing the connection.

Describe the solution you'd like
Specify this duration value via Ingress/Service object annotations.

Describe alternatives you've considered
Configuring manually via awscli or console in meantime.

@shraddhabang shraddhabang added kind/documentation Categorizes issue or PR as related to documentation. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Apr 30, 2024
@shraddhabang
Copy link
Collaborator

/assign ChuksGrinage

@k8s-ci-robot
Copy link
Contributor

@shraddhabang: GitHub didn't allow me to assign the following users: ChuksGrinage.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign ChuksGrinage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@omerap12
Copy link
Contributor

omerap12 commented May 5, 2024

Hey @shraddhabang , are you sure that's documentation issue?

@omerap12
Copy link
Contributor

omerap12 commented May 6, 2024

/assign

@ChuksGrinage
Copy link
Contributor

From what I understand, annotations are just a key/value pairing of the options available to the ALB. And seeing that KAT is a fairly recent addition we can see how our annotation list would be out of date.

@ChuksGrinage
Copy link
Contributor

We can confirm that you can set client keepalive time (KAT) by simply including annotation:
For example: alb.ingress.kubernetes.io/load-balancer-attributes: client_keep_alive.seconds=3600

We are working to update the docs for future references

@omerap12
Copy link
Contributor

omerap12 commented May 8, 2024

@ChuksGrinage so nothing is needed for me then?

@ChuksGrinage
Copy link
Contributor

@omerap12 Yes, no action is needed. Thank you!

@omerap12 omerap12 removed their assignment May 8, 2024
@ChuksGrinage
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

No branches or pull requests

5 participants