Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Support reloading TLS certificates #678

Open
kwohlfahrt opened this issue Dec 11, 2023 · 2 comments
Open

[Feature request]: Support reloading TLS certificates #678

kwohlfahrt opened this issue Dec 11, 2023 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@kwohlfahrt
Copy link

What would you like to be added?

The TLS certificates for the server are loaded only once on startup, see here. This means if the certificate is rotated (e.g. due to expiry), the server will not pick up the new certificate.

Instead, the certificate should be reloaded when the file on disk changes.

Why is this needed?

The kube-apiserver process can't start if the file specified in --authentication-token-webhook-config-file does not exist.

This makes relying on the server to provision certificates a problem during bootstrapping - the apiserver needs the config file to start, and the daemonset needs the apiserver to be up to be deployed.

One way around this is to provision the certificate with some external system, which is then also responsible for rotating the certificate when it is about to expire.

Anything else we need to know?

Certificate reloading functionality is available in the certwatcher package. I'm happy to open a PR integrating this.

@kwohlfahrt kwohlfahrt added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 11, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2024
@kwohlfahrt
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants