New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strange backup in hack/python-sdk/gen-sdk.sh #572

Open

lowang-bh opened this issue Jun 22, 2023 · 2 comments

Member

lowang-bh commented Jun 22, 2023

backup old generated file

mpi-operator/hack/python-sdk/gen-sdk.sh

Line 32 in 21f326d

mv pkg/apis/kubeflow/v2beta1/openapi_generated.go pkg/apis/kubeflow/v2beta1/openapi_generated.go.backup
Then mv backup to cover new generated file event if new generated succeed

mpi-operator/hack/python-sdk/gen-sdk.sh

Line 51 in 21f326d

mv pkg/apis/kubeflow/v2beta1/openapi_generated.go.backup pkg/apis/kubeflow/v2beta1/openapi_generated.go

Why need to cover new generated file with old one?

lowang-bh changed the title ~~strage backup in hack/python-sdk/gen-sdk.sh~~ strange backup in hack/python-sdk/gen-sdk.sh

Member

tenzen-y commented Jun 22, 2023

When we fail to generate codes on our local, we can restore original files from backup.

Member Author

lowang-bh commented Jun 23, 2023

When we fail to generate codes on our local, we can restore original files from backup.

But it will also cover new generated file when succeed, that's also as expect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment