Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment that unroll strategy is disabled if a dedup is present. #185

Open
krlawrence opened this issue Jun 3, 2020 · 0 comments
Open

Comments

@krlawrence
Copy link
Owner

krlawrence commented Jun 3, 2020

Add a short discussion of cases where the RepeatUnrollStrategy does not apply. The most important one being to understand that:

g.V().has('code','AUS').
      repeat(out().dedup()).
        times(7).
      path().
        by('code')

[AUS,YYZ,YUL,YGL,YPX,AKV,YIK,YZG]
[AUS,YYZ,CPH,SFJ,JAV,JUV,NAQ,THU]
[AUS,YYZ,YTS,YMO,YFA,ZKE,YAT,YPO]

Works for that reason. The above will not be unrolled to

out().dedup().out().dedup().out().dedup()..... etc

A forward reference should be added in section "3.27. Shortest paths (between airports) - introducing repeat" and the actual mention of the special casing of repeat steps containing dedup steps should be added in section "5.11.1. Quickly finding the hardest to get to airports". As coverage of strategies is still not included in the manuscript (see issue #11 ) rather than refer to RepeatUnrollStrategy explicitly for now while addressing this issue can just use a more generic language.

@krlawrence krlawrence self-assigned this Jun 3, 2020
@krlawrence krlawrence added this to Low priority in Planning Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Planning
  
Low priority
Development

No branches or pull requests

1 participant