New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL source for audio toolbox #107

Open

kpreid opened this issue Mar 5, 2018 · 1 comment

Assignees

Labels

Owner

kpreid commented Mar 5, 2018

/tools/audio-spectrum and friends can take audio from "user media" devices. I got a request to allow URLs for audio files/streams as well.

Details:

Display the <audio> element so that play/pause/seek controls can be used.
Optional play-through with volume control.
Display errors accessing the URL (especially important as CORS will prevent some from working).
Remember URL across page reloads.
Maybe allow audio URL as a URL parameter as well, so it can be bookmarked/shared. (Maybe switch to URL parameters entirely instead of sessionStorage?)

This will require substantial refactoring of the UserMediaSelector code, but the previous design was kind of awkward and overengineered anyway.

The text was updated successfully, but these errors were encountered:

kpreid added the enhancement label

kpreid self-assigned this

Owner Author

kpreid commented Mar 9, 2018

Commit ec44613

Besides some kludged-together bits, not done from the above list:

Does not display an error on CORS failure.
Does not put the selected source in a URL parameter.

But it works, and also supports local files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment