Fix msgspec template to add field #1942
Conversation
ianbuss
force-pushed
the
retain-ordering-of-fields-with-snake-casing
branch
from
566fb56
to
cf683e4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1942 +/- ##
=======================================
Coverage ? 98.90%
=======================================
Files ? 37
Lines ? 4184
Branches ? 973
=======================================
Hits ? 4138
Misses ? 29
Partials ? 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #1942 will not alter performanceComparing Summary
|
ianbuss
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| from typing import Annotated, Optional | |||
|
|
|||
| from msgspec import Meta, Struct | |||
| from msgspec import Meta, Struct, field | |||
Check notice
Code scanning / CodeQL
Unused import Note
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| from typing import Annotated, List, Optional, Union | |||
|
|
|||
| from msgspec import Meta, Struct | |||
| from msgspec import Meta, Struct, field | |||
Check notice
Code scanning / CodeQL
Unused import Note
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| from typing import List, Optional | |||
|
|
|||
| from msgspec import Meta, Struct | |||
| from msgspec import Meta, Struct, field | |||
Check notice
Code scanning / CodeQL
Unused import Note
With msgspec outputs, the order of generated fields sometimes results in invalid class definitions, with required and optional fields in the wrong order. Additionally, if using
--snake-case-field, field aliases are not added.This PR contains the following fixes:
_has_field_assignmentsort function is modified to sort optional fields last__str__function for msgspec fields is updated to add an explicitNonedefault for optional fields when no other default has been set.field.fieldfor annotated types.test_main.py.Fixes #1943
Fixes #1919
Fixes #1920