Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different thickness for empty arc #164

Open
monovertex opened this issue Aug 29, 2017 · 5 comments · May be fixed by #167
Open

Different thickness for empty arc #164

monovertex opened this issue Aug 29, 2017 · 5 comments · May be fixed by #167
Labels
enhancement question

Comments

@monovertex
Copy link

Would it be possible to have a different thickness for the empty arc behind the filled one?

From an initial look at the code, it should be trivial to add a new parameter that defaults to thickness if not specified.

I can submit a PR if there's no potential blocker with this proposal. Are there any contribution guidelines?
@kottenator
Copy link
Owner

kottenator commented Aug 30, 2017 •
edited

@monovertex - there was a discussion 2 years ago - #24. At that time I didn't have chance to implement it. But I've provided a snippet (which is more a workaround, though).

Feel free to create a pull-request. But don't forget to add corresponding tests ;)

BTW, I have the whole gallery of snippets with various custom things.

@monovertex
Copy link
Author

monovertex commented Sep 1, 2017 •
edited

@kottenator: Thanks for the input and guidelines. I'm on it and an initial implementation is already ready. Got some stuff to iron out for when emptyThickness is larger than thickness and do the tests and then I'll open a PR.

You can assign this to me, if you want.

@monovertex monovertex linked a pull request Sep 12, 2017 that will close this issue
Open
@kottenator
Copy link
Owner

@monovertex - I think your PR is almost fine, but I have one important remark there. Please, take a look.

@monovertex
Copy link
Author

@kottenator: I'm all open for feedback, but there's no comment on the PR. Could you let me know if something went wrong or where could I see that remark?

@kottenator
Copy link
Owner

Sorry, my mistake - I'm new to GH reviews, I didn't publish it. Check now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce emptyThickness parameter monovertex/jquery-circle-progress
2 participants
@kottenator @monovertex