Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arb.list fails within edge cases in case of null values #3981

Closed
oliverblaha opened this issue Apr 25, 2024 · 1 comment
Closed

Arb.list fails within edge cases in case of null values #3981

oliverblaha opened this issue Apr 25, 2024 · 1 comment

Comments

@oliverblaha
Copy link
Contributor

Test case: Arb.list(Arb.constant(null), 1..100).edgecases().forAll { }

Expected: Passes and generates lists of null with a variable length.
Actual: java.util.NoSuchElementException: Collection is empty. in collections.kt, Line 108.

Note: This passes if the lower boundary is set to 0.

Currently, edge cases returning null will lead to the conclusion "there is no edge case for this arb" and subsequently fall back to use a random value. If this is null, too, then the particular edge case for the list is ignored. However, this is not only incorrect (either the edge case or the random value might actually be null), but causes no edge case to be left; therefore the random selection of edge cases fails with "Collection is empty."

I'll submit a PR to address this.

github-merge-queue bot pushed a commit that referenced this issue May 9, 2024
This shall fix the issue as described in
#3981.
Instead of just assuming that a null value means "there is no edge
case", this change adds explicitly checking that, effectively fixing the
problem.
@oliverblaha
Copy link
Contributor Author

Fixed in 5.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant