Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldContain always matches against null map value #3959

Open
hertzsprung opened this issue Apr 2, 2024 · 2 comments · May be fixed by #3965
Open

shouldContain always matches against null map value #3959

hertzsprung opened this issue Apr 2, 2024 · 2 comments · May be fixed by #3965

Comments

@hertzsprung
Copy link

kotest 5.8.1

The following succeeds when it should fail:

mapOf("foo" to "bar") shouldContain ("baz" to null)

due to

kotest/kotest-assertions/kotest-assertions-core/src/commonMain/kotlin/io/kotest/matchers/maps/matchers.kt

Line 10 in 92091b8

value[key] == v,

@AlexCue987
Copy link
Contributor

I can take care of that. Thank you for calling it out!

@AlexCue987 AlexCue987 linked a pull request Apr 5, 2024 that will close this issue
Open
@AlexCue987
Copy link
Contributor

the PR to fix it: #3965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mapcontain (#55) AlexCue987/kotest
2 participants
@hertzsprung @AlexCue987