Makefile and CMake style #871
Comments
|
First-pass added in #872. |
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this issue
Mar 21, 2019
It's generally working as expected you're unlikely to have a file named `clean`. But if you were to create a file named `all` or `clean` you could have a pretty difficult time figuring out why nothing's happening anymore. Cf. koreader/koreader#4819 and koreader#871.
Frenzie
added a commit
that referenced
this issue
Mar 21, 2019
It's generally working as expected you're unlikely to have a file named `clean`. But if you were to create a file named `all` or `clean` you could have a pretty difficult time figuring out why nothing's happening anymore. Cf. koreader/koreader#4819 and #871.
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this issue
Mar 21, 2019
Frenzie
added a commit
that referenced
this issue
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I want to get rid of uppercase commands in the CMake files. It's currently a bit of a hodgepodge with a majority lowercase and I think it negatively affects maintainability (i.e., it takes me more time to scan than I think it should). Cf. https://community.kde.org/Policies/CMake_Coding_Style#Upper.2Flower_casing
Enforcement isn't completely self-evident but cmake-lint would probably do the job for some basic checks, also see https://gitlab.kitware.com/cmake/cmake/issues/17441
On a related note, https://github.com/mrtazz/checkmake exists to do similar things for Makefiles. There's also https://github.com/softprops/mint but at a glance that doesn't seem to do much other than checking if all targets exist.
The text was updated successfully, but these errors were encountered: