-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codacy Permissions #470
Comments
I didn't approve anything new, but I do like the Codacy views.
I don't think there's any integration that'd be relevant to the test data repo.
Never heard of it. |
Correction, Codacy is the one I switched away from in favor of Codecov. Although in this repo it's probably used to do Java static code quality checks. I apologize for answering from my phone, this'd be easier to check on a computer, but no time today. |
Yes, here's a sample commit that came from such static checks. |
I don't know anything about this Codacy. No thought or opinion :/ |
@yparitcher: sorry, I missed the notification :p
Not just for the badge. It does review PR to make sure they're up to standards. See https://app.codacy.com/gh/koreader/android-luajit-launcher/dashboard |
I mean, I can live without it. But the permissions it requests seems quite necessary to do its job. |
I am fine with keeping it, as it does something usefull. |
I got an email from GitHub today that the Codacy GitHub app is requesting additional permissions.
It seems it is being now has access to "Read and write access to checks, commit statuses, issues, organization hooks, pull requests, and repository hooks" And appears to be used only in this repo for the badge. (Which is a broken link).
Is this still relevant?
Also once i looked i noticed that the GitLocalize App has access to the test data repo for localization. Are we still using this?
We also have apporved the Codacy oath app which does not appear to be used, and CodeHub (a Ios github client).
If we are no longer using them we might want to restrict them similar to how we disabled Travis.
Not a big deal, but i believe there is no need to leave access for unused integrations.
@Frenzie
@pazos
@ Not sure / whoever else may have approved or use these?
The text was updated successfully, but these errors were encountered: