Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KopiaUI: Dialog "New Snapshot > Select Folder" is not modal #3819

Open
typpos opened this issue Apr 25, 2024 · 3 comments
Open

KopiaUI: Dialog "New Snapshot > Select Folder" is not modal #3819

typpos opened this issue Apr 25, 2024 · 3 comments
Labels
app KopiaUI App for Windows, macOS & Linux ux User eXperience

Comments

@typpos
Copy link

typpos commented Apr 25, 2024

Win 11 Pro
KopiaUI 0.17.0

  • Snapshots > New Snapshot > Click "Browse Folder"
  • Dialog opens
  • Click "Browse Folder" on the "New Snapshot" panel again

Actual:

  • A second "Select Folder" dialog opens

Expected:

  • No second dialog opens
@lupusA lupusA added bug help wanted app KopiaUI App for Windows, macOS & Linux ux User eXperience good first issue keep-open labels Apr 27, 2024
@lupusA
Copy link
Contributor

lupusA commented Apr 27, 2024

Hi @typpos,

thanks for the hint. It should be easy to fix.

Cheers,

@lupusA
Copy link
Contributor

lupusA commented Apr 27, 2024

Need to correct myself 😄
electron/electron#33351

It won't be fixed i guess.

@typpos
Copy link
Author

typpos commented Apr 27, 2024

I dont' speak electron and am probably out of my depth here, but does Kopia set the parent window when opening the dialog?

ipcMain.handle('select-dir', async (_event, _arg) => {
const result = await dialog.showOpenDialog({
properties: ['openDirectory']
});

For example with remote.getCurrentWindow() ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app KopiaUI App for Windows, macOS & Linux ux User eXperience
Projects
None yet
Development

No branches or pull requests

2 participants