Feature/preview edit links #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kontent-sample-app-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey Nick! Thank you for the PR. 💯 I will put this review into my backlog :) |
|
Hey Nick! We are grateful for your PR. Currently, we are working on a new sample project, which will cover the functionality of using Smartlink SDK. Therefore, your changes might be replaced in the near future (let's say something like in half a year). If you would like to still to merge this PR, let us know. However, there are some things that need to be done, for example:
|
|
If a new sample project is in the works, I think we can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #81
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
This issue was created before Web Spotlight and the Smart Link SDK existed. The suggested solution called out manually creating and rendering edit links. Since the Smark Link SDK exists it became a lot easier to implement this functionality.
Checklist
How to test
If manual testing is required, what are the steps?