Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap goroutines with gowrapper #1699

Open
RebeccaMahany opened this issue Apr 30, 2024 · 0 comments
Open

Wrap goroutines with gowrapper #1699

RebeccaMahany opened this issue Apr 30, 2024 · 0 comments

Comments

@RebeccaMahany
Copy link
Contributor

In #1692, we introduced a wrapper to ensure we log and handle panics in goroutines appropriately. We added this to our rungroups and our windows service. However, there are probably other places in launcher where we would want to log panics from goroutines. This issue is for auditing our codebase and adding gowrapper usage in where appropriate. The linked PR can be used as a guide for making these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant