Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enrollment looks a little amiss #1482

Open
directionless opened this issue Nov 30, 2023 · 0 comments
Open

Re-enrollment looks a little amiss #1482

directionless opened this issue Nov 30, 2023 · 0 comments

Comments

@directionless
Copy link
Contributor

While debugging something unrelated, I noticed that if the server sends down node_invalid: true we don't appear to correctly handle it.

# From Launcher
{"jsonrpc":"","method":"RequestEnrollment","params":{"enroll_secret":... }

# From K2
{"jsonrpc":"2.0","id":1,"result":{"node_key":"nababe::...","node_invalid":false,"err":null}}

# From Launcher
{"jsonrpc":"","method":"RequestQueries","params":{"node_key":"nababe::..."},"id":1}

# From K2
{"jsonrpc":"2.0","id":1,"result":{"node_invalid":true}}

Then it loops. Notable here, is that there is no RequestEnrollment

(I should fix this as part of my enrollment changes in flight)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant