Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode issue #461

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

TimWhiting
Copy link
Collaborator

@TimWhiting TimWhiting commented Feb 3, 2024

Fixes: #458 & #457

There is more work to do to grapheme clusters completely correct, but this is a step in that direction.

See https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundary_Rules for what needs to be done to support this properly.

@erf
Copy link

erf commented Feb 4, 2024

i think the latest Unicode version in use is 15.1 (16 is in draft)

https://www.unicode.org/Public/UNIDATA/EastAsianWidth.txt

@TimWhiting
Copy link
Collaborator Author

i think the latest Unicode version in use is 15.1 (16 is in draft)

https://www.unicode.org/Public/UNIDATA/EastAsianWidth.txt

Thanks for the pointer to a link that doesn't have a hard-coded version in it. I've created a python script so we can make updating this part of our release process.

@erf
Copy link

erf commented Feb 4, 2024

I'm making a script like that myself for my Dart vi-like editor vid . BTW beware the format has changed slightly with the "W" in a different place

@TimWhiting
Copy link
Collaborator Author

I came from the Dart community myself 😄. Glad to see that other people have found Koka.

@erf
Copy link

erf commented Feb 4, 2024

It seems like a great language I'd like to explore ! Although it might still be in a early stage in regards of libraries etc.

@TimWhiting
Copy link
Collaborator Author

It seems like a great language I'd like to explore ! Although it might still be in a early stage in regards of libraries etc.

Yes it is. Libraries can't be done alone though; they require a community. We are getting more active at accepting contributions. I hope you can see the potential for Koka to grow, and become part of the community - at least as an enthusiast, even if it isn't your day job yet :).

@TimWhiting
Copy link
Collaborator Author

One difficult thing about Koka and creating the standard libraries is that Koka includes a bunch of non-standard features that directly affect api design. We are still learning what idiomatic Koka code looks like. You can help with that :).

@erf
Copy link

erf commented Feb 4, 2024

I definitely can see the potential, although I've only recently started looking into it. I do have a lot of things going on right now, so not sure how much i can contribute at the moment, but will keep an eye on it. In my experience building a community requires a strong leader - especially in the initial phase. Keep up the good work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std/text/unicode graphemes does not return a list of grapheme clusters to iterate
2 participants