Offsets are multiplied by 2 when setting image dimension metadata

[imagejan]

When using the Set Image Metadata node to set the dimension name (and nothing else), e.g. Dimension 2 to "Z" (as is required for bitmasks after the Feature Calculator (BETA) node currently - another bug?), the image offsets get multiplied by 2, as illustrated by this workflow:

Set Metadata Offsets Bug.zip

I suspect the issue somewhere in these lines, where the min gets set correctly first, but later the image gets translated by the very same min again:

knip/org.knime.knip.base/src/org/knime/knip/base/nodes/metadata/setimgmetadata/SetImgMetadataNodeModel.java

Lines 242 to 248 in 8aa1488

	final long[] min = new long[imgPlusVal.getDimensions().length];
	imgPlusVal.getImgPlus().min(min);
	for (int i = 0; i < Math.min(min.length, m_offsetColIndices.length); i++) {
	if (m_offsetColIndices[i] != -1) {
	min[i] = ((LongValue)row.getCell(m_offsetColIndices[i])).getLongValue();
	}
	}

knip/org.knime.knip.base/src/org/knime/knip/base/nodes/metadata/setimgmetadata/SetImgMetadataNodeModel.java

Lines 263 to 264 in 8aa1488

	final ImgPlus<T> res = new ImgPlus<>(
	ImgView.wrap(Views.translate(imgPlus.getImg(), min), imgPlus.getImg().factory()), metadata);

Not sure if my guess is correct, though... I only quickly looked at the code.

(Tested with KNIME 3.5.3 and the nightly-built KNIME Image Processing 1.6.1.201806190602)

[imagejan]

(as is required for bitmasks after the Feature Calculator (BETA) node currently - another bug?)

I opened an issue for this one: #506