Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space for iPhone status bar #4

Open
knicholson32 opened this issue Feb 23, 2018 · 1 comment
Open

Add space for iPhone status bar #4

knicholson32 opened this issue Feb 23, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@knicholson32
Copy link
Owner

Issue

When starting the display in portrait mode, a space is carved out for the status bar. Upon transitioning the display to landscape mode and back to portrait mode, the safari webapp recalculates the status bar dimensions and for some reason converts it to black-transparent. There should be a soft-fix for this.

The below images illustrate this transition. Notice the status bar on the left of the display.

img_0364

... transition to landscape and back to portrait ...

img_0365

Proposed Fix

When the display starts up, if it is running on an iPhone and is in portrait mode, it should save the dimensions of the screen. If it ever returns to portrait mode from landscape and the screen width has increased, it should fill the gap with black and float right, creating space for the status bar.

@knicholson32 knicholson32 self-assigned this Feb 23, 2018
@npnicholson npnicholson added the bug Something isn't working label Feb 23, 2018
knicholson32 added a commit that referenced this issue Feb 25, 2018
… portrait mode) and iPad (in all modes) when the app is started in portrait mode. When the app is started in landscape mode on the iPhone, the status bar is not visible, and when rotating to portrait mode, the display overcompensates and leaves space that causes it to overflow. Picture in comments for issue #4.
@knicholson32
Copy link
Owner Author

Mostly addressed with commit 5d33455. Still has the following issues on iPhone only:

Issue 1

Occurs when force reloading the display from portrait mode (through the inspector, after the system has accounted for the status bar space) and then going from landscape to portrait.

  • The display is too tall and overflows on the right side

img_0372

Issue 2

Occurs when opening the display in landscape mode and going to portrait:

  • Status bar is still wrong
  • The display is too tall and overflows on the right side

img_0371

@knicholson32 knicholson32 added this to the First Release milestone Mar 13, 2018
@knicholson32 knicholson32 removed this from the Mid 2019 Release milestone Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants