Unregister element

[dpikt]

If an element no longer needs to be dragged, could it be "unregistered" and removed from the callbacks array? This would help save memory especially in single page apps where several views could potentially be shown or rerendered.

const instance = dragmove(...)
instance.unregister()

// or

const id = dragmove(...)
enddragmove(id)

[knadh]

Ah yes, I'd forgotten about this. Will add an API to detach the event listener.

[obrejla]

Hi @knadh , not removing elements from callbacks array is a really big memory leak and shouldn't be marked as enhancement but rather as a bug, do you plan to fix it? Thanks a lot.

[knadh]

@obrejla I ended up rewriting the whole script to be more memory efficient. It also now lets you unregister elements.

You can find it here: #13

Example:

const d = dragmove(document.querySelector("#test"), document.querySelector("#test .handle"), onStart, onEnd);

d.remove();

Even if you don't remove, the new version keeps track of DOM objects using a WeakMap() that'll automatically garbage collected deleted DOM elements automatically from the map. In addition, functions also no longer leak.

There are no breaking changes. Please give the branch a shot and I'll merge.