Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet Size being escaped #6

Open
lpercifield opened this issue Nov 7, 2016 · 2 comments
Open

Packet Size being escaped #6

lpercifield opened this issue Nov 7, 2016 · 2 comments
Assignees
Labels

Comments

@lpercifield
Copy link
Contributor

In testing with this library, there was a case where an Xbee packet was sent where the packet size byte was escaped. Looks like the simple hack is to add the isEscaped logic to the packet size switch.

@lpercifield
Copy link
Contributor Author

lpercifield@0151e37

@kmark kmark added the bug label Nov 8, 2016
@kmark kmark self-assigned this Nov 8, 2016
@kmark
Copy link
Owner

kmark commented Nov 8, 2016

Thanks for this. I remember figuring out exactly how escaping worked (and when it wasn't necessary) took a lot of time and trial/error. Looks like I missed some things. If you send a PR I'll accept as-is since I'm not too worried about the code quality of this implementation at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants