[Bug] overlay with point in the future does not saving right

[oneart-dev]

Version

9.5.9

Steps to Reproduce

1. Draw segment or any 2 point overlays with second point beyond last candle (future)
2. Check overlay points data

Current Behavior

If check points data it will looks li that:

{
"points":[{"timestamp":1687420800000,"value":0.09349152777777778},{"value":0.1189336111111111}]}
}

It will lead to bugs if saving it and restore later

Expected Behavior

Chart should calculate timestamp based on interval and point location or do not let user to make point in the future

Environment

- OS: Macos
- Browser: any
- Framework: not related

Any additional comments?

No response

[oneart-dev]

Screen.Recording.2023-06-26.at.11.54.11.mov

[oneart-dev]

Best possible fix probably will be draw invisible candles all the way to the right.
Sadly "performEventMoveForDrawing" do not provide kline data at all, so it really hard to implement dirty fix to stop users from drawing beyond last candle

[oneart-dev]

I fixed it in my repo by updating it in OverlayView.ts function _coordinateToPoint:

   if (this.coordinateToPointTimestampDataIndexFlag()) {
      const xAxis = chart.getPaneById(PaneIdConstants.XAXIS)?.getAxisComponent() as Axis
      const dataIndex = xAxis.convertFromPixel(coordinate.x)
      const timestamp = timeScaleStore.dataIndexToTimestamp(dataIndex) ?? undefined
      const klines = chart.getChartStore().getDataList()
      if (timestamp === undefined) {
        const index = dataIndex < 0 ? 0 : dataIndex > klines.length - 1 ? klines.length - 1 : dataIndex
        point.timestamp = klines[index].timestamp
        point.dataIndex = index
      } else {
        point.dataIndex = dataIndex
        point.timestamp = timestamp
      }
    }

[liihuu]

It may not be necessary to change the source code, listen to the onDrawing of overlay, and then determine if it exceeds the boundary, forcing a reassignment of points.

[Basttyy]

It may not be necessary to change the source code, listen to the onDrawing of overlay, and then determine if it exceeds the boundary, forcing a reassignment of points.

I noticed this too

[oneart-dev]

But its not a solution for the problem. If library can't handle it should force it by default.

[xtrmus]

KLineChart._.Features.preview.-.Google.Chrome.22.09.2023.09_49_57.online-video-cutter.com.mp4

Likewise, if the starting and ending points are too far apart, the overlay remains hidden when LoadMore is not performed.

(Even if it is within Timestamp borders)