Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone method #63

Open
qaraluch opened this issue Sep 21, 2018 · 0 comments
Open

clone method #63

qaraluch opened this issue Sep 21, 2018 · 0 comments
Labels
feature request Request for a new feature

Comments

@qaraluch
Copy link

qaraluch commented Sep 21, 2018

Is your feature request related to a problem? Please describe.
One way to clone Signale instance is through .scope() method. Wouldn't be convenient if you could clone instance for change just interactivity without changing its scope, like this:

const interactive = signale.clone({ interactive: true }); 

It seems pretty easy to change in the code base:

  clone(configObj) {
    return new Signale(Object.assign(this.currentOptions, ...configObj));
  } 

What are your thoughts about this idea?

@klaudiosinani klaudiosinani added the feature request Request for a new feature label Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants