Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash of incorrect style when loading Zimit ZIMs with DarkReader or when using the random button #514

Open
Jaifroid opened this issue Dec 21, 2023 · 1 comment

Comments

@Jaifroid
Copy link
Member

While I have eliminated FOIS when using links within a loaded ZIM that has DarkReader enabled, incorrect style is still showing in the following circumstances:

  • Loading a ZIM for the first time, or pressing the Home button
  • Using the random button

These are minor issues, and it is a matter of porting the code that waits for DarkReader to have installed itself before showing the contents of the iframe, but it should be done for aesthetic reasons (and, marginally as an a11y issue).

@Jaifroid Jaifroid added this to the Release 3.0.0 milestone Dec 21, 2023
@Jaifroid Jaifroid self-assigned this Dec 21, 2023
@Jaifroid Jaifroid modified the milestones: Release 3.0.0, Release 3.1.0 Dec 28, 2023
@Jaifroid Jaifroid changed the title Flash of incorrect style when loading a Zimit ZIM for first time with DarkReader or when using the random button Flash of incorrect style when loading Zimit ZIMs with DarkReader or when using the random button Feb 1, 2024
@Jaifroid
Copy link
Member Author

Jaifroid commented Feb 1, 2024

FOIS now affects most Zimit v2 ZIMs with DarkReader. The reason is because these ZIMs are faster to read (due to the pre-processing). It is difficult to detect when DarkReader has completed its transformations (this is some time after the enabled flag is set), so we have to introduce more time-based delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant