Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report unchecked type-assertion when returning value and when passing it to other func #224

Open
leonklingele opened this issue Jan 29, 2023 · 1 comment · May be fixed by #246
Open

Report unchecked type-assertion when returning value and when passing it to other func #224

leonklingele opened this issue Jan 29, 2023 · 1 comment · May be fixed by #246
Labels
bug help wanted

Comments

@leonklingele
Copy link

Two false negatives here when using the -asserts flag:

package main

func main() {
	var i interface{} = "hello"

	_ = handleInterface(i)

	handleString(i.(string)) // This should be reported but isn't
}

func handleInterface(i interface{}) string {
	return i.(string) // This should be reported but isn't
}

func handleString(s string) {}
@leonklingele
Copy link
Author

Also, this is not caught:

if i.(string) == "hello" {
    ..
}

ngehrsitz pushed a commit to ngehrsitz/evcc that referenced this issue Sep 10, 2023
Switch to forcetypeassert since errcheck does not find everything
d2cb046 
kisielk/errcheck#224
@meteorgan meteorgan linked a pull request Apr 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(type assert): add more check for type assert meteorgan/errcheck
2 participants
@kisielk @leonklingele