Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highcharts released an official React wrapper, is this library still relevant now? #413

Open
dandv opened this issue Jul 18, 2018 · 5 comments

Comments

@dandv
Copy link

dandv commented Jul 18, 2018

On April 11, 2018, Highcharts announced an official React wrapper that they had been working on for a year.

Is this library still useful? How does it compare with the official React wrapper?

@sknutsonsf
Copy link

Please add the answer from #138 (linked above) to the FAQ or as part of the package description.

@kirjs
Copy link
Owner

kirjs commented Oct 13, 2019

Closing and there has been no activity in this issue for a while.
if this is still relevant, please feel free to reopen

@kirjs kirjs closed this as completed Oct 13, 2019
@dandv
Copy link
Author

dandv commented Oct 14, 2019

Who can/should provide more activity on the issue?

I'd have no problem whatsoever with closing it, if the README mentioned the official wrapper.

As things are right now, this library has 3x the number of GitHub stars vs. the official wrapper. I think it's a matter of intellectual honesty to link to the official wrapper, and advise developers how this library differs from it. Other libraries do that.

@kirjs kirjs reopened this Oct 14, 2019
@kirjs
Copy link
Owner

kirjs commented Oct 14, 2019

@dandv +1 for mentioning official wrapper as well at the alternative one in the docs.
You're welcome to create an PR, or one of use would do it later

dandv added a commit to dandv/react-highstock that referenced this issue Oct 18, 2019
@dandv
Copy link
Author

dandv commented Oct 18, 2019

@dandv +1 for mentioning official wrapper as well at the alternative one in the docs.
You're welcome to create an PR, or one of use would do it later

PR created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants