Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

Use --network-namespace-path= instead of relying on ns.Set() #348

Open
arianvp opened this issue Sep 28, 2019 · 1 comment
Open

Use --network-namespace-path= instead of relying on ns.Set() #348

arianvp opened this issue Sep 28, 2019 · 1 comment

Comments

@arianvp
Copy link

arianvp commented Sep 28, 2019

I was wondering why we don't set --network-namespace-path=<path-to-ns>

In cnispawn, Would be something like:

path := ns.Path()

nspawnOpts := append(nspawnOpts, fmt.Printf("--network-namespace-path=%s", path))

Instead, we seem to be calling ns.Set(). Which can be a bit unsafe in presence of goroutines (https://github.com/containernetworking/plugins/blob/master/pkg/ns/README.md)

@arianvp
Copy link
Author

arianvp commented Sep 28, 2019

This is more of a question out of interest then a request or a bug report. Feel free to close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant