Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--first-commit-add does not have any effect #65

Open
jogc opened this issue Sep 8, 2021 · 3 comments
Open

--first-commit-add does not have any effect #65

jogc opened this issue Sep 8, 2021 · 3 comments

Comments

@jogc
Copy link

jogc commented Sep 8, 2021

Regardless if I put 0 or 1000 or nothing for first-commit-add it does not make any difference for the number of hours calculated.

$ git-hours 
{
  "X": {
    "name": "X",
    "hours": 233,
    "commits": 1218
  },
  "total": {
    "hours": 233,
    "commits": 1218
  }
}
$ git-hours --first-commit-add=0
{
  "X": {
    "name": "X",
    "hours": 233,
    "commits": 1218
  },
  "total": {
    "hours": 233,
    "commits": 1218
  }
}
$ git-hours --first-commit-add=1000
{
  "X": {
    "name": "X",
    "hours": 233,
    "commits": 1218
  },
  "total": {
    "hours": 233,
    "commits": 1218
  }
}
$ git-hours --version
1.5.0

It seems --max-commit-diff might have the same problem. Just installed git-hours with npm.

@lowlyocean
Copy link

I can confirm this as well

@danielmhanover
Copy link

seems like every option has no effect on the output now

@nathanfranke
Copy link

nathanfranke commented Oct 17, 2023

@kimmobrunfeldt There hasn't been an update since 1.5.0, so this is still a problem. https://www.npmjs.com/package/git-hours

Workaround:

  • npm r -g git-hours
  • npm i -g https://github.com/kimmobrunfeldt/git-hours

And the --since argument works for me now.

(P.S. Instead of using sudo with npm -g, set NPM_CONFIG_PREFIX, in my case export NPM_CONFIG_PREFIX="$HOME/.local")
(P.P.S. Installation takes a long time, 15+ minutes, perhaps because my ipv6 isn't working)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants