Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 12 issues with Xcode10 #40

Open
4 tasks
southfox opened this issue Sep 26, 2018 · 1 comment
Open
4 tasks

iOS 12 issues with Xcode10 #40

southfox opened this issue Sep 26, 2018 · 1 comment

Comments

@southfox
Copy link

Hi guys,

awesome repository, we are using this for our application, thanks for sharing this.

I've been trying to build for iOS 12 under Xcode 10 and I'm having the following issues:

 //  BaseWindow.swift
...
       backgroundColor = UIColor.clear
        windowLevel = UIWindow.Level.alert + 1
        
        makeKey()

// CircularProgressView.swift

  • = 'didEnterBackgroundNotification' has been renamed to 'NSNotification.Name.UIApplicationDidEnterBackground'
        NotificationCenter.default.addObserver(self,
                                               selector: #selector(viewDidEnterBackground(_:)),
                                               name: UIApplication.didEnterBackgroundNotification,
                                               object: nil)
  • = 'willEnterForegroundNotification' has been renamed to 'NSNotification.Name.UIApplicationWillEnterForeground'
//  CircularProgressView.swift
        NotificationCenter.default.addObserver(self,
                                               selector: #selector(viewWillEnterForeground(_:)),
                                               name: UIApplication.willEnterForegroundNotification,
                                               object: nil)

Do you want me to send a PR for these issues?
Thanks again.

@southfox
Copy link
Author

southfox commented Sep 26, 2018

Hi, I've just publish a PR here to fix issue #39 and issue #40, could you review? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant