Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bqf slow #74

Open
teto opened this issue Sep 5, 2022 · 3 comments
Open

bqf slow #74

teto opened this issue Sep 5, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@teto
Copy link

teto commented Sep 5, 2022

Feature description

I love bqf but it slows down moving between quicklist items noticeably (200ms - 500ms I suppose). I am using neovim master but this has been the case for months.

Describe the solution you'd like

I've seen #33, is it still up to date ?

At https://github.com/kevinhwang91/nvim-bqf#setup-and-description (Iw would suggest to start with "require'bqf'" else someone has to look up the name of the module to import), there is a "delay_syntax" option I am not sure would help. Does it delay highlighting so that bqf can display the file immediately ?

Additional context

I have treesitter disabled.

Now that I am writing this I wonder if I enable options that accentuate the slowness. Is there a way I can customize the bqf popup to disable (relative)number for instance ?

@teto teto added the enhancement New feature or request label Sep 5, 2022
@kevinhwang91
Copy link
Owner

I've seen #33, is it still up to date ?

Only add an extra winid for quickfix as a parameter, and the code should work.

there is a "delay_syntax" option I am not sure would help. Does it delay highlighting so that bqf can display the file immediately ?

Yes, unless your buffer content is large enough, shouldn't be slow.

I have treesitter disabled.

bqf only optimizes treesitter highlighting, vim regex highlighting may be slow.

Is there a way I can customize the bqf popup to disable (relative)number for instance ?

I'm not clear about what you said above, could you explain it clearly? Maybe a screenshot or video would help.

@teto
Copy link
Author

teto commented Sep 5, 2022

I'm not clear about what you said above, could you explain it clearly? Maybe a screenshot or video would help.

when bqf creates its preview window, I would like to be able to set window-local options such set nonumber, i.e., during an on_create_window callback or via an autocmd that can distinguish bqf preview windows from other windows.

I will try reenabling treesitter but the tradeoff for treesitter was negative for me (so far).

@kevinhwang91
Copy link
Owner

when bqf creates its preview window, I would like to be able to set window-local options such set nonumber, i.e., during an on_create_window callback or via an autocmd that can distinguish bqf preview windows from other windows.

Don't support it for now. If you think it's necessary to customize the number, I can add an option like

nvim-bqf/README.md

Lines 203 to 206 in aac1ff9

wrap = {
description = [[wrap the line, `:h wrap` for detail]],
default = false
},
.

I will try reenabling treesitter but the tradeoff for treesitter was negative for me (so far).

I have no any perf issue about treesitter after I customize the query.

  1. Remove some parser like comment, and reduce the injection language as little as possible, queries/foo/injections.scm.
  2. Reduce inefficient predicates, :h lua-treesitter-predicates for detail, queries/foo/highlights.scm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants