Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Setting CorrectDrift to False causes wfc.py in Stage 4 to crash #639

Closed
2 tasks done
astroRez opened this issue Apr 1, 2024 · 2 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@astroRez
Copy link
Collaborator

astroRez commented Apr 1, 2024

FAQ check

  • Yes, I checked the FAQ and my question has not been addressed.

Instrument

Other (any stage)

What happened?

Because lc.driftmask isn't created when correctDrift is set to False, an error is raised stating lc.driftmask doesnt exist.
To resolve this, please change line 82 in wfc3.py of Stage 4 from:

lc.driftmask['time'] = time

to

if meta.correctDrift: 
    lc.driftmask['time'] = time

Which seems to resolve the issue.

Error traceback output

No response

What operating system are you using?

No response

What version of Python are you running?

No response

What Python packages do you have installed?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@astroRez astroRez added the bug Something isn't working label Apr 1, 2024
kevin218 added a commit that referenced this issue Apr 5, 2024
@taylorbell57
Copy link
Collaborator

@kevin218, I see you already made a commit that resolves this in some branch (I can't tell which) - did you want to make a PR with that commit?

@kevin218
Copy link
Owner

It was merged with #641. We can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants