Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Merge differentiable and standard models if possible #591

Open
1 task done
taylorbell57 opened this issue Dec 13, 2023 · 0 comments
Open
1 task done

Comments

@taylorbell57
Copy link
Collaborator

taylorbell57 commented Dec 13, 2023

Instrument

Light curve fitting (Stages 4-6)

What is your suggestion?

At present, there are separate implementations of the numpy-based and theano-based astrophysical and detector models which requires twice as much work if someone wants to add a new model or wants to change how a current model works. It will be a bit tricky to write things in a way that is fast for numpy-based models but also works for theano-based models (for-loops aren't slow for the latter since it gets compiled, but for-loops can be quite slow for the former), but I think for most cases it should be quite doable. Once we've worked out how to do it well for one of them, it should be very easy to extrapolate to the other functions

Code of Conduct

  • I agree to follow this project's Code of Conduct
@taylorbell57 taylorbell57 added the enhancement New feature or request label Dec 13, 2023
@taylorbell57 taylorbell57 self-assigned this Dec 13, 2023
@taylorbell57 taylorbell57 added this to To do in Stage 5: Light Curve Fitting via automation Dec 13, 2023
@taylorbell57 taylorbell57 added this to To do in Road to v1.1 via automation Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LC Fit
Development

No branches or pull requests

3 participants