Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to Modal Presentation Style #78

Open
Errortype520 opened this issue Sep 13, 2016 · 4 comments
Open

Changes to Modal Presentation Style #78

Errortype520 opened this issue Sep 13, 2016 · 4 comments

Comments

@Errortype520
Copy link

The changes made to modal presentation style, from UIModalPresentationCustom to UIModalPresentationOverCurrentContext seems to have broken most, but not all of my popups.

It works from any view controller I have presented modally, but not on any root view controllers. I am at a loss for why.
@kevin-lyn
Copy link
Owner

@Errortype520 broken means the popup is not showed at all?

@Errortype520
Copy link
Author

Yes, I am unsure why, but switching this back to UIModalPresentationCustom keeps my popups showing.

@Errortype520
Copy link
Author

Errortype520 commented Oct 2, 2016 •
edited

It is possible it is a conflict with SlideMenuController or another library I am using

@jakubheglas
Copy link

I second this one. It'd be great to make this either a public property or make it .overFullScreen (which imo makes more sense for far more use cases). Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakubheglas @kevin-lyn @Errortype520