👋 thanks for the pull request.

Regarding "[?] I have performed a self-review of my changes", I'm not sure the ? is because you don't understand the choice item, but I'll explain:

• after you pushed your changes, you made sure (in GitHub, since that's what we'll use to review initially) you pushed exactly what you want

Tests failing...

Are these changes consistent in the fish and C shell activation scripts?

manpath -g does not seem to work in macOS, so manpath alone seems like an Ok solution.

i think its because the CI checks the manpath after activation, and now there is the docker state included...

also sorry i neglected the csh/fish activation

also sorry i neglected the csh/fish activation

No prob. We'd eventually either do it, or, at the very least, identify it as an issue 😄, but since you updated it, it's most welcome.

As per CI you might need to run shellcheck tests/activate_test.sh or maybe update the file as per the CI results and re-push.

Would it make this all simpler if we:

1. fetch MANPATH with manpath
2. update a variable (maybe we don't need to check if it's set or not)
3. do cleanup upon deactivate

?

I'd need to test this better, maybe I'm missing a detail, but the current implementation seems much more complex than required 😕 @jadeallenx, thoughts?

Yeah I agree the current situation isn’t great and could be simplified

idk how i'd alter the tests, but the new failures seem to be that the expected_env is presumed to be the same on different calls/users, so it'd have to use something like grep $EXPECTED over the actual MANPATH, rather than literal equality

idk how i'd alter the tests, but the new failures seem to be that the expected_env is presumed to be the same on different calls/users, so it'd have to use something like grep $EXPECTED over the actual MANPATH, rather than literal equality

You could potentially also validate that it's, as expected, the concatenation you build.

idk how i'd alter the tests

You mean you don't know where to start, or what to do?

You can look at the tests folder for examples, or run your own, by writing a Bash script (exit with 1 on error, otherwise 0).

Closing as stale (also, all CI is failing). Feel free to re-open and apply the required changes.