Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark bad variable name #51

Open
hscstudio opened this issue Feb 8, 2016 · 15 comments
Open

Benchmark bad variable name #51

hscstudio opened this issue Feb 8, 2016 · 15 comments

Comments

@hscstudio
Copy link

I just do this benchmark on my droplet Digital Ocean, I have git clone, and do

sh setup.sh laravel-5.1/ ci-3.0/ yii-2.0/

Success, but when I do

sh benchmark.sh laravel-5.1/ ci-3.0/ yii-2.0/

produce following error

benchmark.sh: 12: export: ci-3.0/: bad variable name

But if benchmark one by one its run well

sh benchmark.sh laravel-5.1/
@kenjis
Copy link
Owner

kenjis commented Feb 9, 2016

I don't know why only benchmark.sh produce the error.
It seems they are using the same code.

How about this?

sh benchmark.sh laravel-5.1 ci-3.0 yii-2.0

@hscstudio
Copy link
Author

It's same. produce the erorr too.

now, I comment and uncomment file list.sh, so I can benchmark specific framework only.

cebe added a commit to cebe/php-framework-benchmark-1 that referenced this issue Feb 11, 2016
@cebe
Copy link
Contributor

cebe commented Feb 11, 2016

@hscstudio can you please check, if my pull request (#52) fixes it?

@hscstudio
Copy link
Author

still produce same error

@kenjis
Copy link
Owner

kenjis commented Feb 13, 2016

What shell do you use?

@hscstudio
Copy link
Author

I use putty to acces my droplet in DO

@kenjis
Copy link
Owner

kenjis commented Feb 14, 2016

@hscstudio No, no. It is not your shell. It is your terminal application or ssh client application.

Please run the command below in DO environment:

$ echo $SHELL

You can see the shell which you use.

@Fly06-Fr
Copy link

First at all, thank you for providing us with this benchmarking tool, this is really usefull.

I just wanted to mention that I run into the same problem and managed to solved it by using the right shell command (so "bash benchmark.sh ..." instead of "sh benchmark.sh ..." in my case).

http://www.linuxquestions.org/questions/linux-newbie-8/a-simple-bash-command-causing-bad-variable-name-790082/

@kenjis
Copy link
Owner

kenjis commented Mar 18, 2016

@Fly06-Fr
Thank you for your information!

@hscstudio
Please try this:

$ bash benchmark.sh laravel-5.1/ ci-3.0/ yii-2.0/

@Fly06-Fr
Copy link

Hi Kenjis,

Memory statistics are always null in the table summary.

Any clue about this?

Thanks.

@kenjis
Copy link
Owner

kenjis commented Mar 18, 2016

You can't get them, if you don't use Apache.

@Fly06-Fr
Copy link

I'm using Apache.

So what's wrong?

@kenjis
Copy link
Owner

kenjis commented Mar 18, 2016

Do you see memory statistics when you see hello world pages with your brower?

@Fly06-Fr
Copy link

My fault sorry.

I didn't have the correct DocumentRoot in my Apache conf. It's ok now.

I have a last question: How should I proceed to add another framework to your benchmarking tool?

@kenjis
Copy link
Owner

kenjis commented Mar 19, 2016

See source code of existing frameworks, please.
For example, https://github.com/kenjis/php-framework-benchmark/commits/master/ci-4.0-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants