Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only sampledBy is past tense #277

Open
mAAdhaTTah opened this issue Apr 6, 2018 · 0 comments
Open

Only sampledBy is past tense #277

mAAdhaTTah opened this issue Apr 6, 2018 · 0 comments
Labels
Milestone

Comments

@mAAdhaTTah
Copy link
Collaborator

I don't know if this is a huge deal, but I think it's a little odd that, of the "Combine 2 Observables" methods, sampledBy is the only one written in past tense. The others are all filterBy, bufferBy, etc. I'd like to propose deprecating sampledBy in favor of sampleBy, making all of them consistently present tense.

I don't know if / when we're considering a 4.0, but that's probably a long-future away anyway, so deprecating and changing this over might be worth doing now and thinking about what we may want to include in a (potential) 4.0 release.

@mAAdhaTTah mAAdhaTTah added this to the 4.0 milestone Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant