Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_btrfs() returns incorrect value for btrfs filesystems directly on LUKS volumes #109

Open
sten0 opened this issue Jun 23, 2022 · 0 comments

Comments

@sten0
Copy link
Contributor

sten0 commented Jun 23, 2022

Affects master branch an[d] current stable release 0.5.

  1. On a system where a btrfs filesystem exists directly on a LUKS volume.
  2. Where this fs is mounted using /dev/mapper/foo in /etc/fstab.
  3. btrfsmaintenance-functions:L21 returns '/dev/mapper/foo' rather than a mount point.
  4. Which means 'stat -f --format=%T' in is_btrfs() returns tmpfs.
  5. This means 'BTRFS_SCRUB_MOUNTPOINTS="auto"' in the config file skips all filesystems that match conditions one and two.
  6. The user expectation for "auto" to work properly is not met.
  7. Unfortunately, the is_btrfs check at btrfs-scrub.sh:39 means 'BTRFS_SCRUB_MOUNTPOINTS="/mount/point/for/LUKS_btrfs_fs"' will also fail, and thus cannot be used as a workaround. Additionally the expectation that an explicitly specified mount point will be scrubbed is not met.

Please fix this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant