Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Changes needed for integration tests #118

Open
lucernae opened this issue Sep 7, 2021 · 2 comments
Open

[RFC] Changes needed for integration tests #118

lucernae opened this issue Sep 7, 2021 · 2 comments

Comments

@lucernae
Copy link
Collaborator

lucernae commented Sep 7, 2021

We need a way to test the repo changes as proposed here:

I have no familiarity so far with the stack to determine if the images needs to have it's own unit test. So far we have 3 separate image under one repo. It may need a separate discussion.

At the moment, we can focus on an integration tests (tests that makes sure the stack works as one single services).

To do this, we need to have a clear goals on what needs to be tested:

  • we should have small/minimum test dataset with predictable result, as the input
  • what to test? connections? schema? final results of the data?
  • if possible let’s use test framework like python unittest, so it can be described and added easily
  • where to test? I guess we can only rely on GitHub action for now, since it uses docker-compose. hopefully it is under the github action test limit.

Requesting for comments from @timlinux @NyakudyaA @Gustry

@lucernae
Copy link
Collaborator Author

lucernae commented Sep 7, 2021

I proposed in the slack channel that the dataset for the tests should be stored in a public location that we can control (possibly the pbf files, clip geojson, and the yml mapping files). We can use MinIO datastore instance that Kartoza have for that. Currently not public, but we can arrange the permission later so that it is publicly fetch-able.

@frafra
Copy link
Contributor

frafra commented Sep 27, 2022

I agree. This is totally needed, together with pinning dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants