Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"notifications" field missing in configRaw #34

Open
Nicholaiii opened this issue Oct 11, 2021 · 2 comments
Open

"notifications" field missing in configRaw #34

Nicholaiii opened this issue Oct 11, 2021 · 2 comments

Comments

@Nicholaiii
Copy link

Using the example config throws an error because the config type doesn't have a notifications field.

@Nicholaiii
Copy link
Author

It also throws using the notifications field on a service.

field notifications not found in type struct { Checks []struct { Name string; Interval patrol.duration; Timeout patrol.duration; Cmd patrol.checkCmd; Type string; MetricUnit string "yaml:"unit"" }; OnFailure []*patrol.singleNotificationConfig "yaml:"on_failure""; OnRecovered []*patrol.singleNotificationConfig "yaml:"on_recovered""; OnSuccess []*patrol.singleNotificationConfig "yaml:"on_success"" }

@karimsa
Copy link
Owner

karimsa commented Oct 11, 2021

Hey! Thanks for trying out patrol.

The example config is unfortuanately incorrect. You should be able to use a top-level or service-level on_failure, on_recovered, and on_success. Just a note - notifications are only partially supported right now. You'll be able to fire off webhooks, but the templating isn't available yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants